search

sharkdp / insect

High precision scientific calculator with support for physical units
https://numbat.dev/
MIT License
3.18k stars 126 forks source link

Update dependencies #326

Closed triallax closed 2 years ago

triallax commented 2 years ago

I was thinking that maybe it would be better if I just committed stuff like this directly to master. @sharkdp is this okay with you?

sharkdp commented 2 years ago

Please feel free to commit minor things (e.g. typos, documentation changes, etc.) to master directly. For larger changes, I would appreciate PRs as usual. For things in between (like this), maybe just quickly open a PR (which allows me to follow the development process via GitHub notifications) and then merge it yourself once CI has passed, without waiting for an approval.

I personally follow a similar procedure because I have broken CI too many times in my projects with "minor changes" that could not possibly break anything …

Does that sound okay?

sharkdp commented 2 years ago

Another thing: please feel free to open branches on this repo as well. There's no need to work in your fork, unless you want to.

triallax commented 2 years ago

Please feel free to commit minor things (e.g. typos, documentation changes, etc.) to master directly. For larger changes, I would appreciate PRs as usual. For things in between (like this), maybe just quickly open a PR (which allows me to follow the development process via GitHub notifications) and then merge it yourself once CI has passed, without waiting for an approval.

I personally follow a similar procedure because I have broken CI too many times in my projects with "minor changes" that could not possibly break anything …

Does that sound okay?

Yeah, that makes sense.

Another thing: please feel free to open branches on this repo as well. There's no need to work in your fork, unless you want to.

Yeah, I'm aware I can do that, but I'm used to always creating PR branches in my forks.