search

sharkdp / insect

High precision scientific calculator with support for physical units
https://numbat.dev/
MIT License
3.18k stars 126 forks source link

Cache Spago dependencies and purs output in CI #373

Closed triallax closed 1 year ago

triallax commented 1 year ago

Fixes https://github.com/sharkdp/insect/issues/342.

sharkdp commented 1 year ago

Thank you for looking into this. I am usually very careful with caching in CI. If we absolutely must bring down CI times, that's certainly a good idea. But I have seen too many hard-to-debug errors that appeared because cache-invalidation didn't work for some reason (see your example with compiler versions, for example).

triallax commented 1 year ago

That is a valid concern. Just to be clear, the compiler versions thing I mentioned was just a thing to investigate before implementing this; I do not know of any cases where it was an actual issue. Anyway, I think this comment and this one show that this should be safe. Additionally, resetting the cache or disabling this is trivial should it ever prove to be an issue.

sharkdp commented 1 year ago

Additionally, resetting the cache or disabling this is trivial should it ever prove to be an issue.

That's the thing. Sometimes it's hard to know (or remember) that CI problems could be related to caching.

But I'm okay with giving this a try. Thank you!