search

sharkdp / pastel

A command-line tool to generate, analyze, convert and manipulate colors
Apache License 2.0
5k stars 97 forks source link

add option to force the use of a specified colorpicker #102

Closed danieledapo closed 4 years ago

danieledapo commented 4 years ago

This should close #96

sharkdp commented 4 years ago

Thank you very much for your contribution!

sharkdp commented 4 years ago

wait.. now we have two colorpicker_tools files?

danieledapo commented 4 years ago

wait.. now we have two colorpicker_tools files?

ooops, I forgot to remove one :sweat_smile:

sharkdp commented 4 years ago

@d-dorazio did you see my PR on your fork?

danieledapo commented 4 years ago

@sharkdp I did not (for some reason I didn't get the notification), but after a quick look I'm not too sure that's a better approach. It's probably simpler, but I think it also increases compilation time a bit without any big advantages imho. Please see https://github.com/d-dorazio/pastel/pull/1#issuecomment-539455295 for further details.

sharkdp commented 4 years ago

Okay, fair enough. Thank you for the feedback. Let's go with your approach.

sharkdp commented 4 years ago

Thank you!