sharkdp / pastel

A command-line tool to generate, analyze, convert and manipulate colors
Apache License 2.0
4.98k stars 97 forks source link

Make code coverage purely informational (not allowed to break the build) #126

Closed rivy closed 4 years ago

rivy commented 4 years ago

Code coverage can break the build occasionally, for, IMO, undesirable reasons.

Lastly, if you don't like the CodeCov "chattyness" is your PRs (eg, https://github.com/sharkdp/pastel/pull/125#issuecomment-633257909), the first line of .codecov.yml can be changed to comment: false disabling the commentary. Lots of other configuration options are available but are really beyond my understanding/uses.

sharkdp commented 4 years ago
* Occasionally, the code coverage upload will fail due to unknown factors. The first commit should convert those failures to just warnings.

:+1: Already had a build failure due to a failed upload yesterday

* And, second, if CodeCov is allowed, it can signal a build failure if coverage drops for a commit/PR. The second commit here adds a _.codecov.yml_ configuration file that converts CodeCov comments to purely informational; builds always "pass". If you want it to fail for drops, there are lots of options, but I never found a set that I liked ... hence, info but always pass setting.

Sounds good, thank you

Lastly, if you don't like the CodeCov "chattyness" is your PRs (eg, #125 (comment)), the first line of .codecov.yml can be changed to comment: false disabling the commentary

I was a bit surprised, but I'll take it for now - thank you!