search

sharkdp / shell-functools

Functional programming tools for the shell
MIT License
1.2k stars 49 forks source link

Add negate flag to filter #25

Closed vegarsti closed 6 years ago

vegarsti commented 6 years ago

I gave the first option you proposed for #4 a shot, by adding --negate as a flag in commands.py. It's only used in filter thus far. I'm really open to this not being the best solution!

(Adding --not as a flag wasn't possible, due to it being a keyword, as far as I understand.)

vegarsti commented 6 years ago

I'm really sorry about making those small commits.

vegarsti commented 6 years ago

Thanks for being so welcoming! This is a really cool (and useful) project! I have addressed your changes now. (Not sure if I can change the "Changes requested" to "Waiting for review" or something like that?)

sharkdp commented 6 years ago

Thanks for being so welcoming! This is a really cool (and useful) project!

You're welcome, thank you for the feedback.

(Not sure if I can change the "Changes requested" to "Waiting for review" or something like that?)

That'd be nice, but I don't think there is anything like this on Github.

sharkdp commented 6 years ago

Thank you very much!