search

sharksforarms / deku

Declarative binary reading and writing: bit-level, symmetric, serialization/deserialization
Apache License 2.0
1.05k stars 54 forks source link

Add support for specifying the ID's endianness #337

Open mpalmer opened 1 year ago

mpalmer commented 1 year ago

I've got a need to specify the endianness of a discriminator, without having that propagate to substructures. Hence this little change.

Great crate, BTW; well-documented and easy to use!

sharksforarms commented 1 year ago

I've got a need to specify the endianness of a discriminator, without having that propagate to substructures

You've peaked my interest, is this a public data-format? Sounds funky.

mpalmer commented 1 year ago

I've not stared at Miri output much before, but the failures I examined do not appear to be related to the changes I made.

wcampbell0x2a commented 1 year ago

I've not stared at Miri output much before, but the failures I examined do not appear to be related to the changes I made.

Yah, we really should disable those, or just disable the ones we know fail? Miri doesn't really like bitvec, and I don't think those issues will be fixed anytime soon.