Fix hygiene in gen_internal_field_ident

sharksforarms / deku

Declarative binary reading and writing: bit-level, symmetric, serialization/deserialization

Apache License 2.0

1.05k stars 54 forks source link

Fix hygiene in gen_internal_field_ident #366

Closed ghost closed 7 months ago

ghost commented 9 months ago

Change generated ident prefix to __deku___ (three underscores) so that emitted field reads are immediately obvious in expanded code, although I think two underscores would be valid as well.
Also add a field to test_named_struct.

sharksforarms commented 6 months ago

FYI @interruptinuse I'm now see'ing

Variable `__deku___size` should have snake_case name, e.g. `__deku_size` [non_snake_case]`

in my editor :eyes:

ghost commented 6 months ago

Oh, my bad 👀!

~My first instinct was to add #[allow(non_snake_case)], however, it might not be sufficient (rust-lang/rust-analyzer#6541)~. EDIT: nevermind! The macro was just missing the attrs in another couple places.