search

sharksforarms / deku

Declarative binary reading and writing: bit-level, symmetric, serialization/deserialization
Apache License 2.0
1.05k stars 54 forks source link

Remove unused DekuWrite trait #419

Closed wcampbell0x2a closed 1 month ago

wcampbell0x2a commented 4 months ago

These are now unused, because internally we just now use DekuWriter

github-actions[bot] commented 4 months ago

Benchmark for 53caf58

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | deku_read_bits | 1223.5±14.65ns | **1158.5±16.13ns** | **-5.31%** | | deku_read_byte | 5.8±0.16ns | 5.8±0.05ns | 0.00% | | deku_read_enum | 2.9±0.04ns | 2.9±0.04ns | 0.00% | | deku_read_vec | 36.6±1.06ns | 36.4±0.38ns | -0.55% | | deku_write_bits | 175.2±3.55ns | 174.4±2.38ns | -0.46% | | deku_write_byte | 21.1±0.43ns | 21.1±0.47ns | 0.00% | | deku_write_enum | 20.4±0.19ns | 20.5±0.31ns | +0.49% | | deku_write_vec | 438.4±2.63ns | **287.9±5.82ns** | **-34.33%** |
sharksforarms commented 2 months ago

@wcampbell0x2a no longer sure of the status on this one

wcampbell0x2a commented 2 months ago

@wcampbell0x2a no longer sure of the status on this one

Now it's updated

github-actions[bot] commented 2 months ago

Benchmark for 2867195

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | deku_read_bits | **1161.1±15.39ns** | 1186.5±14.93ns | **+2.19%** | | deku_read_byte | 5.5±0.15ns | 5.4±0.13ns | -1.82% | | deku_read_enum | 2.9±0.06ns | **2.6±0.08ns** | **-10.34%** | | deku_read_vec | 36.1±0.58ns | 36.5±0.75ns | +1.11% | | deku_write_bits | 163.3±3.82ns | **154.0±3.92ns** | **-5.70%** | | deku_write_byte | 22.1±0.94ns | 22.1±0.39ns | 0.00% | | deku_write_enum | 20.8±0.34ns | 20.8±0.45ns | 0.00% | | deku_write_vec | 298.4±2.70ns | **286.0±4.77ns** | **-4.16%** |
sharksforarms commented 2 months ago

@wcampbell0x2a could you update the PR description? Why are these unused?