search

sharksforarms / deku

Declarative binary reading and writing: bit-level, symmetric, serialization/deserialization
Apache License 2.0
1.05k stars 54 forks source link

Missing magic changed to be a unique error vs a parsing error #440

Open Nub opened 1 month ago

Nub commented 1 month ago

This change is needed so parsers that work on stream data can know wether to advance into the buffer to find a valid message without having to manually search for magic bytes before feeding the DekuRead object.

Nub commented 1 month ago

Thanks! Check the CI, there are some other errors.

Will do! Shoulda marked this as a draft while I was working on that, apologies.

Nub commented 1 month ago

What version of the toolchain is being used, compiler outputs being used for tests without pinning a version is what's causing some of these CI failures. I had been on a nightly 1.80 which apparently changes the output of the compiler, fun fun!

wcampbell0x2a commented 1 month ago

What version of the toolchain is being used, compiler outputs being used for tests without pinning a version is what's causing some of these CI failures. I had been on a nightly 1.80 which apparently changes the output of the compiler, fun fun!

Yah I usually use nightly and then use cargo +stable test before commits. The toolchain used in CI is the stable one.