Closed wcampbell0x2a closed 1 month ago
@wcampbell0x2a is this ready for review / 0.18? I'll need to allocate some time to review this one
@wcampbell0x2a is this ready for review / 0.18? I'll need to allocate some time to review this one
Let's leave this off. I'll also need time to review and check all of these changes again.
Closing, rebased with https://github.com/sharksforarms/deku/pull/483
Benchmark for 09e5363
Click to view benchmark
| Test | Base | PR | % | |------|--------------|------------------|---| | deku_read_bits | 1167.8±15.75ns | **1151.4±26.14ns** | **-1.40%** | | deku_read_byte | 3.3±0.18ns | 3.3±0.07ns | 0.00% | | deku_read_enum | 2.6±0.07ns | **2.5±0.05ns** | **-3.85%** | | deku_read_vec | 33.4±0.17ns | 33.5±0.23ns | +0.30% | | deku_write_bits | **181.1±3.81ns** | 227.3±8.01ns | **+25.51%** | | deku_write_byte | 22.8±0.48ns | **21.5±0.39ns** | **-5.70%** | | deku_write_enum | 21.4±0.39ns | **20.8±0.44ns** | **-2.80%** | | deku_write_vec | 398.9±6.73ns | **292.9±7.52ns** | **-26.57%** |