search

sharkwouter / minigalaxy

A simple GOG client for Linux
https://sharkwouter.github.io/minigalaxy/
GNU General Public License v3.0
1.1k stars 71 forks source link

Psychonauts 2: Wine extraction failed #550

Open LeXofLeviafan opened 1 year ago

LeXofLeviafan commented 1 year ago

I've just tried installing Psychonauts 2 using minigalaxy (v1.2.2); it spent a while downloading the ~30Gb file, then froze my system for a minute, and after that deleted the file and declared that "Wine extraction failed"…

Here's the kicker though: the file it downloaded is named psychonauts_2_1097251_56084.sh. Seems like the installer code fails to realize that the downloader code fetched a linux installer (…also the game tile seems to have a Wine icon so I'm guessing the main window also shares this delusion; then again, it shows a Wine icon even for games that were setup with other runner types, i.e. DOSBox games).

LeXofLeviafan commented 1 year ago

…It appears that GOG API says this game only has a Windows version, even though both the store page and the library (downloads) page say otherwise.

Still, if it manages to fetch a linux installer, then it should be run as a linux installer, should it not?

LeXofLeviafan commented 1 year ago

…After some testing, I seem to have determined how it gets there: get_info() fetches downloads information, then get_download_info() initially checks for a linux installer (incidentally, if it fails it fetches the info again, also discarding the dlc_installers value altogether, instead of passing installers and averting both issues), but the information on which installer got scheduled for download appears to be never propagated to the installer code.

BTW, this only happens when minigalaxy thinks the game isn't installed – when it (mistakenly) detected the game as installed once (I guess it created an empty folder on previous install attempt and forgot to delete it?), it tried to "update" the game by downloading Windows installer (though there didn't seem to be any progress to it).

LeXofLeviafan commented 1 year ago

…Incidentally, after I installed the Linux version manually, it got detected correctly as a Linux one (and displayed without a Wine icon in the game list).

sharkwouter commented 1 year ago

Sorry for the late response and thanks for the report. I'm glad GOG fixed the issue on their side.

A lot of the bahavior you describe Minigalaxy doing here is a bit funky, though. I'll keep this open for now.

sharkwouter commented 1 year ago

Thanks for the detailed description of what's happening btw, that is really helpful.