search

sharkwouter / minigalaxy

A simple GOG client for Linux
https://sharkwouter.github.io/minigalaxy/
GNU General Public License v3.0
1.09k stars 70 forks source link

Move the Gametile menu button alongside the Play button #558

Closed lmeunier closed 1 year ago

lmeunier commented 1 year ago

Not sure of this pull-request as this is an opinionated change.

The menu button, located at the top right corner of the thumbnail, is barely visible for some games. I think it would be better the have this button alongside of the action button (play/download/...). Should we keep the previous icon ("applications-system-symbolic") or use the default icon for GtkMenuButton?

Also, the first letter of the action button is now capitalized.

Any comments are welcome (I'm not very confident with Gtk).

Before: Screenshot from 2023-02-19 16-12-29

After: Screenshot from 2023-02-19 16-11-17

sharkwouter commented 1 year ago

Oh nice, that's really cool!

lmeunier commented 1 year ago

In order to update all translation files, all I have to do is run the script ./scripts/update-translation-files.sh?

Should I also change the gametilelist.ui/.py files? To be honest, I was not aware that the game tiles could be displayed as a list, I just discovered this feature :)

sharkwouter commented 1 year ago

I'd say the best way to update the translations would actually be to go into the .po files and replace the translations for these words which are already there with the capitalized ones. Here would be an example: https://github.com/sharkwouter/minigalaxy/blob/766cc7c7071fdd4759c38991114a9ffe5da7646d/data/po/cs_CZ.po#L626

Just running the update script will not yield the result we want, as it will make new entries and the old ones will be ignored.

lmeunier commented 1 year ago

Translations for msgid "Play" have been added and some translations for msgid "Install" have been fixed.

sharkwouter commented 1 year ago

I've cherry-picked the commits which did not involve the updates to the strings and translation files. Thanks for this change! I don't think I can merge the rest of this right now. Maybe it would be better to have a separate PR for that part.

lmeunier commented 1 year ago

Maybe it would be better to have a separate PR for that part.

I agree with you. I'll prepare a new PR with only the Capitalization of the first letter. I think we can close this PR now.

sharkwouter commented 1 year ago

Cool, thanks again for the contribution!