search

sharkwouter / minigalaxy

A simple GOG client for Linux
https://sharkwouter.github.io/minigalaxy/
GNU General Public License v3.0
1.11k stars 72 forks source link

many wine and native linux games break when installed to another drive like an external #569

Open Snuzzums opened 1 year ago

Snuzzums commented 1 year ago

I think a "junction" when installed to other drives should fix this. I will try to junction the external install and point it to the default install location, but because all the folders for the games change the directory for each game individually, thus messing with where their install/execution scripts point to, I don't think I'll be too successful. I will look into how to write a junction in shell later today. If you guys could work on it when you get the chance that would be cool, as anything I make will just be a band-aid, not a real solution.

Thanks ahead of time, -Andrew

Snuzzums commented 1 year ago

Update: I got the "junction" which is just a symbolic link working, and minigalaxy "thought" my external GOG folder was the one in $home folder, but it didn't fix any of the games that were acting up. I tried, sorry I couldn't be of more help.

-Andrew

sharkwouter commented 1 year ago

Thanks for the report @Snuzzums, shame you could not reproduce it. I think there are some issues with installing Windows games when innoextract is not installed. I'm not sure if that is what you were seeing. I hope it's not an issue that is seen by a lot of people.

spillner commented 1 year ago

I ran into something similar (although I was not installing to a different drive) with several games, including but not limited to King's Quest IV and Thief II. Minigalaxy's installation process would run and mark the game as "installed", but the actual game installer never launched and the only thing left in the game directory was the generic WINE prefix. Other games with near-identical installers (e.g. King's Quest V, Thief I) would work just fine on the same system.

Your comment about innoextract prompted me to upgrade it from version 1.3 to 1.9, and so far all of the previously-failed games now install successfully. I presume the underlying issue is that old versions of innoextract fail on certain .cab files, but Minigalaxy should be able to detect and handle these failures more gracefully, e.g. by informing the user that innoextract exited abnormally, cleaning up the vanilla prefix/ directory, and not treating the game as installed in the Minigalaxy UI.

sharkwouter commented 1 year ago

That's good to know, thanks for the update. I'll keep that in mind for when people bring up similar issues.