search

sharma66mahesh / ShadowShift

MIT License
8 stars 2 forks source link

use typescript #4

Open kishorliv opened 8 months ago

kishorliv commented 8 months ago

At the moment, it is becoming very difficult to add code because there's no type completion. its very easy to write buggy code with js so lets migrate the codebase to typescript. We need to add @types/chrome to get autocompletion for chrome extension apis. I can jump on this if you want.

sharma66mahesh commented 8 months ago

That's a valuable suggestion. However, I propose we postpone it for now and prioritize getting the extension to function without bugs. I'll keep this issue open for now, so this doesn't get lost.

kishorliv commented 8 months ago

I mean there aren't any obvious bugs that i know of atm. This is the thing with js, there's no types and suggestions so no way to know the signatures without going through the docs... i think its probably better to migrate to typescript sooner rather than later as there's not a lot of code now...

sharma66mahesh commented 8 months ago

I assume you were working with https://github.com/sharma66mahesh/ShadowShift/issues/2 .
I'll be focusing on getting the extension published on chrome store, for the next few days.

But if you can get started with the typescript migration as well, I don't have any problems with with