sharparchitecture / Sharp-Architecture

S#arp Architecture: ASP.NET MVC Best Practices with NHibernate
http://sharparchitecture.github.io/
Other
593 stars 153 forks source link

Update to NHibernate 5 #161

Closed jgbright closed 6 years ago

jgbright commented 6 years ago

NHibernate 5 was released in October, 2017. It includes support for asynchronous data access using async/await among other things.

http://nhibernate.info/blog/2017/10/10/nhibernate-5-0-released.html http://enterprisecraftsmanship.com/2017/12/11/nhibernate-async-support/

cd21h commented 6 years ago

@jgbright Waiting for 5.1 with NetStandard2 support. Also are you aware of any FluentNHibernate development going on? It does not seem to be up to date. Can you suggest any alternative for fluent mapping?

jgbright commented 6 years ago

With regard to FluentNHibernate development activity, I see a pull request that addresses updating the referenced version of NHibernate. That is the only activity I am aware of.

https://github.com/jagregory/fluent-nhibernate/pull/386

I could attempt to use my current SharpArchitecture based project with NHibernate 5, but I suspect it will be unreliable. I can install the NHibernate 5 nuget pacakge by using the ignore dependencies option. I can ensure the NHibernate 4 references go to NHibernate 5 using binding redirects. There would also need to be updates among NHibernate's dependencies Antlr and Iesi.Collections.

If FluentNHibernate is not maintained and I have trouble, I could always switch over to using NHibernate's own NHibernate.Mapping.ByCode mapping system.

jrgcubano commented 6 years ago

@jgbright @shatl

We shipped the new version of FluentNHibernate.

Sorry for the delay.

cd21h commented 6 years ago

Awesome!

On Feb 18, 2018 9:06 AM, "Jorge Rodríguez Galán" notifications@github.com wrote:

@jgbright https://github.com/jgbright @shatl https://github.com/shatl

We shipped the new version of FluentNHibernate.

Sorry for the delay.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sharparchitecture/Sharp-Architecture/issues/161#issuecomment-366518530, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIu0dy26Uo9E5B-aNFnfzMxgPihVEbqks5tWC5qgaJpZM4Rwx5K .

cd21h commented 6 years ago

@jgbright I hope to find some time to work on this next week

lucaarpaia commented 6 years ago

@jgbright hi, relative to your comment about

I could attempt to use my current SharpArchitecture based project with NHibernate 5, but I suspect it will be unreliable. I can install the NHibernate 5 nuget pacakge by using the ignore dependencies option. I can ensure the NHibernate 4 references go to NHibernate 5 using binding redirects. There would also need to be updates among NHibernate's dependencies Antlr and Iesi.Collections.

have you perhaps tested that? How did it worked? I have a SharpArchitecture based project currently relying on version 3.0.0 and I'm planning an upgrade to 4.0.1 (with NHibernate 4). I would also need to use Envers which latest release works with NH5 so the attempt you commented about could be a way for me too, and to have someone already tested similar approach would help :)

thank you

cd21h commented 6 years ago

Waiting for FluentNHibernate/fluent-nhibernate/issues/390 @jrgcubano to finish NetStandard2.0 upgrade

jgbright commented 6 years ago

@lucaarpaia I did not try it. We ended up postponing this work.

cd21h commented 6 years ago

@jgbright Please try https://www.nuget.org/packages/SharpArch.NHibernate/5.0.0-unstable0010 It is in early beta but I got all unit-test passed :)