Introduce general purpose data type result (e.g. float/decimal) instead of short, sbyte and int. - Githubissues

sharpbrick / powered-up

.NET implementation of the LEGO PoweredUp Protocol

MIT License

98 stars 19 forks source link

Introduce general purpose data type result (e.g. float/decimal) instead of short, sbyte and int. #126

Closed tthiery closed 3 years ago

tthiery commented 3 years ago

Sub Integer Scaling is currently blocking higher results outputs.
Upscaling can lead to exceptions

Acceptance Criteria

[x] Use double as a universal number representation (LWP specs sbyte, short and int and float => all covered in double with sufficient precision)
[x] Change formatters to emit doubles (optionally) (#160)
[x] Unit Test before and after modification (add separate issue (#161) /PRs, merge first to master and then to pull request)

In #177 all modes are reviewed and investigated if they need to be updated. Will be done over time.