Blue giga issue 77 - Githubissues

dkurok commented 3 years ago

Bluegiga implementation for use with BLED112-dongle

tthiery commented 3 years ago

Hi @dkurok ... Awesome work. Your Pull Request is now so much more ... C# stylish ;)

Regards master branch / git: As long as the pull request is still building and has no conflicts, I can squash it without issues.
You re-code some of the CLI/Example toolings to use now BlueGiga... that I cannot merge currently (since default on Win10 is WinRT for most devices and I do not yet have dynamic loading on Linux. How about introducing an argument to select the bluetooth adapter
Also, update the README, both with your name (if you like) and the support for the chip.

After that, give me a sign and I merge it.

dkurok commented 3 years ago

Sorry, something did go wrong with my branching! It generated a new PR on your side; I thought I first merged my own branch into my main and then I could do a PR / it updates the PR by itself...but NO, it generated a new PR on your site (https://github.com/sharpbrick/powered-up/pull/145) So I think you can delete this (#140 ) and only need to treat on 145

tthiery commented 3 years ago

Happy git learning. Git and GitHub are really different animal. When you want to experiment, create local branches on your cloned repo. No Pull Request. A "Pull Request" is when you say your code is ready into the main repo and request that I pull it. Basically you offer a patch.

tthiery commented 3 years ago

Closed in favor of #145

sharpbrick / powered-up

Blue giga issue 77 #140