search

sharpbrick / powered-up

.NET implementation of the LEGO PoweredUp Protocol
MIT License
98 stars 19 forks source link

Add Color&Distance Sensor (#88007) as a Device #141

Closed highstreeto closed 3 years ago

highstreeto commented 3 years ago

This adds the Color&Distance Sensor as ColorDistanceSensor.

The following outputs are implemented currently:

Closes #103 non-breaking

tthiery commented 3 years ago

I had an initial pass over the contribution. Looks good so far. Tell me when you are done, then I can review and merge it.

I will have a breaking v4.0 (on .NET 5) version within the next month. Is that early enough for you?

tthiery commented 3 years ago

Oh, and please also update the README.md ... that is always a nice closure ;)

highstreeto commented 3 years ago

I had an initial pass over the contribution. Looks good so far. Tell me when you are done, then I can review and merge it.

I will have a breaking v4.0 (on .NET 5) version within the next month. Is that early enough for you?

I am not in a rush (as I can use my fork in the meantime), so early or late April works for me.

Oh, and please also update the README.md ... that is always a nice closure ;)

Done

tthiery commented 3 years ago

Are you done with the contribution? In that case I would merge it.

highstreeto commented 3 years ago

Are you done with the contribution? In that case I would merge it.

So now should be done, I changed the deltaInterval for color and count to 1 (which makes more sense)

tthiery commented 3 years ago

I just saw a commit message which stated you have not tested with real hardware: Have you by now?

I was squashing already ;)

highstreeto commented 3 years ago

I just saw a commit message which stated you have not tested with real hardware: Have you by now?

I was squashing already ;)

Ah, I tested with the real sensor since the 'Add test for ColorDist. sensor ' commit. I wrote this in my first commit, as I had to wire up to infrastructure code to handle the Color&Dist. sensor