Re-implement DiscoverPorts based on a request/response architecture

sharpbrick / powered-up

.NET implementation of the LEGO PoweredUp Protocol

MIT License

98 stars 19 forks source link

Re-implement DiscoverPorts based on a request/response architecture #148

Closed tthiery closed 3 years ago

tthiery commented 3 years ago

Currently the DiscoverPorts works in an event style programming matters. It fires many port discovery requests and awaits their responses. While this might have some performance benefits, with fast adapters it might overload the hub.

A better architecture is a request / response pair.

See conversation around #145

tthiery commented 3 years ago

Pre Refactoring Test Run (Technic Medium Hub + 2 XL Motors): 30s
Post Refactoring Test Run: 33s => acceptable
Output Identical