Make PoweredUp infrastructure adhere to HubId

sharpbrick / powered-up

.NET implementation of the LEGO PoweredUp Protocol

MIT License

99 stars 19 forks source link

Make PoweredUp infrastructure adhere to HubId #23

Closed tthiery closed 4 years ago

tthiery commented 4 years ago

Generally the library is not supporting multiple HubIds over the same bluetooth device/service/gatt profile.

[x] CommonMessageHeaderEncoder.Encode hardcoded 0x00
[x] Most Hubs, Devices do not encode their hub id into the commands
[ ] Host/Hubs need to recognize their associated HubId

... Many more issues

tthiery commented 4 years ago

HubId is currently not retrievable (current understanding of spec). The Specification also talks about using the HubId statically encoded to 0x00. Hub Networking might introduce a change here.

Decision: Leave it in the factory for now (close to manufacturer data). No further premature design. Overall, all components should adhere to their HubId and correctly handle it from a variable.