search

sharpbrowser / SharpBrowser

A full featured web-browser built using C# and CefSharp
MIT License
896 stars 392 forks source link

Would it be worth releasing a distribution for non-developers? #57

Closed LandarXT closed 2 years ago

LandarXT commented 2 years ago

There could be an (albeit small) percentage of people who may wish to get the software through traditional installation means, so perhaps we could offer this? I would be more than happy to be the one to compile these builds if this goes ahead.

robinrodricks commented 2 years ago

Whom do you suppose will be the potential users? As a browser its a pretty crappy product compared to say Chrome or Brave. My only reason for developing this was that developers who needed a white label browser or automatable browser could use this as a base.

LandarXT commented 2 years ago

I htought possibly people who needed a lightweight and fast browser, or those who simply didn't need all of the features of say Chrome, I understand there wouldn't be too high of a userbase but it's not really too much effort to zip up or create an MSI installer for the browser every week or two in my opinion.

Also, there is no reason we can't implement more advanced features in the future, as CefSharp is still being developed and is a pretty capable framework.

robinrodricks commented 2 years ago

Yes a setup could be made, but I really doubt if we can compete with professional browser developed for 20+ years. An InnoSetup build would be easy to make, since VDProj is now dead. Yes advanced features are always welcome.

LandarXT commented 2 years ago

I have made an example Inno Setup installer here. As you can see it is a fully featured installer and only took around five minutes to make.

We could possibly make these builds every 1-2 weeks and if even 1 person uses it, I personally believe it would be beneficial for possibly evolving this browser. If you do not want to spend time making these builds, I could easily make them for you. However, if you truly believe there is no use for this installer, I am more than happy to accept your opinion as you are the project author.

LandarXT commented 2 years ago

By the way, as I see you do not agree with this, I have made the browsextra fork to release under my own branding - I will still contribute upstream

robinrodricks commented 2 years ago

By the way, as I see you do not agree with this, I have made the browsextra fork to release under my own branding - I will still contribute upstream

I don't disagree with you, its just been difficult keeping up with all the open source projects going around.

I would ask that you do not fork as that would fracture the community further, as it is we have very few contributors.

You can make a setup build and place it under a 'setup' folder and make a PR for the same. You can then make another PR adding a link from the readme to the setup to 'advertise' it. Whatever other changes you want to make, you are free to raise PRs.

robinrodricks commented 2 years ago

Also make a PR for adding the innosetup description file into the repo.

robinrodricks commented 2 years ago

We could possibly make these builds every 1-2 weeks and if even 1 person uses it, I personally believe it would be beneficial for possibly evolving this browser.

You are free to do it, I don't personally have the time to do it, but any updates you make you are free to raise PRs and I accept most PRs submitted.

robinrodricks commented 2 years ago

Please note I am not recieving github alerts for this project, as it is under a different user name (sharpbrowser rather than my name). So if you want me to reply to something please tag me like @robinrodricks .

robinrodricks commented 2 years ago

Hi @LandarXT - Can you please make a PR and include the innosetup project file inside the setup folder? So that way I or any other OSS user can also make a setup if needed.