search

sharpchi / moodle-atto_templates4u

Templates button for Moodle's atto text editor
1 stars 7 forks source link

Add new setting to enable button only for given users and cleanup #4

Closed adpe closed 4 years ago

adpe commented 5 years ago

Hello @sharpchi

I've done some improvements.

Looking forward to your response, Adrian

adpe commented 4 years ago

Hi @sharpchi

Do you have time to have a look to it, please?

Greets Adrian

sharpchi commented 4 years ago

Hi Adrian, sorry it's taken so long to look at this. I'm having a think about the permission thing - since the editor can appear in all sorts of contexts, is manageactivities always the right permission to check? I wonder if creating a capability is the better way to go?

There are also different sorts of updates in this pull request, which I think I might treat as separate items.

adpe commented 4 years ago

Hi @sharpchi

I've taken that code base from https://github.com/dthies/moodle-atto_fullscreen/blob/master/lib.php#L36-L51

As we're using that plugin as well.

But I can make a new PR with a new plugin permission which is not based on other capabilities.

Does it sound good?

Greets, Adrian