search

sharpchi / moodle-filter_syntaxhighlighter

14 stars 11 forks source link

Line numbers #1

Open michalciolek opened 6 years ago

michalciolek commented 6 years ago

Hello!

Could you add this: https://github.com/wcoder/highlightjs-line-numbers.js#usage to your Moodle Plugin to show line numbers?

sharpchi commented 6 years ago

Hi Michal, thanks for the suggestion, I hadn't seen that plugin.

I don't currently have time to do this, but if you wish to make a pull request to implement it, as long as the numbering is optional, I'll see about incorporating it.

Mark

michalciolek commented 6 years ago

Hi sharpchi, I tried to implement highligtjs-line-number in your plugin but unfortunately I failed because library is not in AMD format (Uncaught Error: No define call for)... I'm not a specialist in JS.. If you can fix it you can find my code at https://github.com/michalciolek/moodle-filter_syntaxhighlighter/commit/4aceceb0c3e1af06fd4d2c19efdcb6f4ffdaa767

fishfree commented 10 months ago

+1 Line numbers are very important for teaching.