search

sharpchi / moodle-filter_syntaxhighlighter

14 stars 10 forks source link

Failing core tests test_requirejs #20

Open dmitriim opened 2 years ago

dmitriim commented 2 years ago

The plugin fails one of the core Moodle tests. Tested in Moodle 3.9. See below. 

There was 1 failure:

1) core_requirejs_testcase::test_requirejs
Failed asserting that '/var/www/moodle39/filter/syntaxhighlighter/amd/build/hljs.js' contains ".min".

/var/www/moodle39/lib/tests/requirejs_test.php:91
/var/www/moodle39/lib/phpunit/classes/advanced_testcase.php:80

To re-run:
 vendor/bin/phpunit "core_requirejs_testcase" lib/tests/requirejs_test.php

FAILURES!
Tests: 1, Assertions: 1998, Failures: 1.
dmitriim commented 2 years ago

Fix for that issues https://github.com/sharpchi/moodle-filter_syntaxhighlighter/pull/21

dmitriim commented 1 year ago

Hi @sharpchi ! Any chance you can have a look at this issue and related PR? Thanks!

mazitov-az commented 7 months ago

Hi @sharpchi ! We also have a similar problem. We use Moodle 4.1 Предложенное решение кажется хорошим! #21 Thanks!