Closed jkoritzinsky closed 6 years ago
Will first publish a preview package to make some diffs with https://www.fuget.org, if you can help me checking we haven't any regression compare to pre 4.0.x
And oops sorry, forgot to say thank you! 😉
So starting to look at the diff for example XAudio2: https://www.fuget.org/packages/SharpDX.XAudio2/4.2.0-ci259/lib/netstandard1.1/diff/4.0.1/ Max/Min was previously remapped to Maximum/Minimum.
Quite a good chunk of ResultCode disappeared from SharpDX.Direct2D1 https://www.fuget.org/packages/SharpDX.Direct2D1/4.2.0-ci259/lib/netstandard1.1/diff/4.0.1/
(Don't know if it is a codegen issue or the result codes have been moved to a file we don't handle anymore)
It looks like the main differences from 4.0.1 are naming things like that and #1028. Only other difference I've seen is better property generation. Can you file an issue for the naming differences?
Same for Direct3D11 https://www.fuget.org/packages/SharpDX.Direct3D11/4.2.0-ci259/lib/netstandard1.1/diff/4.0.1/
In previous codegen there was a special handling of short names to expand them, haven't checked how/if it is handled by SharpGenTools?
That should be handled the same as before. I have unit tests for it too. I'll take a look and see if I can repro the naming issues.
GetFrequencyRatio and Set are methods instead of props
SetFrequencyRatio doesn't correctly fit the form for a property, so that one should be manually re-added IMO.
Can you open an issue on SharpGenTools/SharpGenTools with the naming issues? I can't work on it at the moment but will take a look later.
Update SharpGenTools and MSBuild.Sdk.Extras.
Fix #1044 Fix #1037 Fix #1036 Fix #1035