sharpdx / SharpDX

SharpDX GitHub Repository
http://sharpdx.org
MIT License
1.68k stars 641 forks source link

SharpDX.DirectWrite.FontFallbackBuilder.AddMapping method signature is incorrect #1086

Open calbonaler opened 5 years ago

calbonaler commented 5 years ago

In original IDWriteFontFallbackBuilder::AddMapping method, the type of targetFamilyNames parameter is const WCHAR **. But, in its wrapper, SharpDX.DirectWrite.FontFallbackBuilder.AddMapping method, the parameter type is string instead of string[].

Also, rangesCount and targetFamilyNamesCount parameters are redundant because they are computed from corresponding arrays' length.