sharpdx / SharpDX

SharpDX GitHub Repository
http://sharpdx.org
MIT License
1.68k stars 642 forks source link

Implementing vertical field of view #1117

Open Muzzarino opened 5 years ago

Muzzarino commented 5 years ago

The vertical aspect ratio should be extendable by aspect ratio if below the conditional width ratio (for instance: the calculation of the vertical height scale is divided with 4:3 by 16:9 and the horizontal width is locked to 16:9) so I wanted to make the parameter part of the perspective field of view matrix.

xoofx commented 5 years ago

This would be a breaking change to the existing API. You should probably create a version with this parameter, and redirect the previous implementation to this new one using a default parameter for this new parameter