search

sharpdx / SharpDX

SharpDX GitHub Repository
http://sharpdx.org
MIT License
1.7k stars 639 forks source link

XAudio2 HRTF APO Support #737

Open timber-schroeder opened 8 years ago

timber-schroeder commented 8 years ago

XAudio2 (xaudio2_9.dll only) now has a built-in HRTF audio processor, are there any plans to add support for it under SharpDX.XAPO.Fx? MSDN Page for CreateHrtfApo This would be great to have, especially with VR becoming a larger audience.

xoofx commented 8 years ago

Good to know that they have added a new effect. I currently don't have time to work on this, but PR are welcome!

christopheHurter commented 7 years ago

This may help but this is not .NetCore UWP and does not work for the Hololens.

https://github.com/snada/managed-xaudio2-hrtf

snada commented 7 years ago

Hey @christopheHurter thanks for signaling my small library.

I won't take that as a good example of implementation of this feature. I just needed hrtfs on a personal project, so I pretty much slapped some code here and there to have a working prototype without taking the challenge to implement this in a huge project like SharpDX.

I was watching this issue though: @xoofx if you still think hrtfs are worth exploring in SharpDX it would be awesome to give it a shot. Are there guidelines or docs to start contributing?

christopheHurter commented 7 years ago

Hrtf technology definitely worth being investigated espectialy with Hololens. For me two options exists:
a C++ boxing similar to what you have done but with the support of .NetCore a c# wrapper similar to https://github.com/sharpdx/SharpDX/tree/master/Source/SharpDX.XAudio2/Fx

xoofx commented 7 years ago

It is probably a few minutes of work in SharpDX to bring this method. Just look into the mapping.xml files and the way existing FX functions are mapped.

christopheHurter commented 7 years ago

I managed to generate the code and to compile it but I failed to find the suitable way to bring to life the requeted methods. I may need some more help. Can you consider sending me some additional instructions (direct mail @enac.fr, to avoid spoiling this thread)?

xoofx commented 7 years ago

@christopheHurter Open a PR, we will try to fix them from there.