search

sharpdx / SharpDX

SharpDX GitHub Repository
http://sharpdx.org
MIT License
1.7k stars 638 forks source link

Latest sharpdx fails windows store certification! (4.0.1) #939

Closed SirDragonClaw closed 7 years ago

SirDragonClaw commented 7 years ago

We have updated our engine to use SharpDX 4.0.1 and now our game fails the windows store verification because of illegal dlls in SharpDX.

Supported API test

FAILED Error Found: The supported APIs test detected the following errors:

API MFCreateAudioRendererActivate in mf.dll is not supported for this application type. SharpDX.MediaFoundation.dll calls this API. API MFCreatePresentationClock in mf.dll is not supported for this application type. SharpDX.MediaFoundation.dll calls this API. API MFCreateMuxStreamAttributes in mfplat.dll is not supported for this application type. SharpDX.MediaFoundation.dll calls this API. API MFCreateMuxStreamMediaType in mfplat.dll is not supported for this application type. SharpDX.MediaFoundation.dll calls this API. API MFCreateMuxStreamSample in mfplat.dll is not supported for this application type. SharpDX.MediaFoundation.dll calls this API. API MFCreateSensorGroup in mfplat.dll is not supported for this application type. SharpDX.MediaFoundation.dll calls this API. API MFCreateSensorStream in mfplat.dll is not supported for this application type. SharpDX.MediaFoundation.dll calls this API.

Impact if not fixed: Using an API that is not part of the Windows SDK for Windows Store apps violates the Windows Store certification requirements.

What can be done about this?

xoofx commented 7 years ago

They need to be discarded in SharpDX codegen:

https://github.com/sharpdx/SharpDX/blob/9db524770d6250e7c81d400102b77cbfc0c5cb58/Source/SharpDX.MediaFoundation/Mapping-core.xml#L1019-L1028

PR welcome.

SirDragonClaw commented 7 years ago

940

I have made the required changes and everything seems to build correctly, it would be great if these could be tested and accepted and pushed to nuget.

xoofx commented 7 years ago

I have made the required changes and everything seems to build correctly, it would be great if these could be tested and accepted and pushed to nuget.

This should be part of the 4.1.0 pre-release nuget package (should be pushed in a few minutes)

devedse commented 5 years ago

I just tried to submit a package using MonoGame and SharpDX 4.2.0, however I'm still seeing some errors in the Package Certification:

image

Shall I open a new issue?

https://github.com/MonoGame/MonoGame/issues/5003#issuecomment-446193549

devedse commented 5 years ago

Tagging @xoofx

xoofx commented 5 years ago

For GetModuleHandle/LoadLibrary, It looks like a regression coming from 556aee5cd01b7dfa4ded256ef7510f57bcb9df0e by @Ziriax

The code should be only valid for DESKTOP_APP.

For the MF function, similar fix to this issue should be done.

PR Welcome.

devedse commented 5 years ago

@xoofx , could you check my pull request?