search

sharpdx / SharpDX

SharpDX GitHub Repository
http://sharpdx.org
MIT License
1.69k stars 641 forks source link

Various improvements and cleanup #943

Closed amerkoleci closed 6 years ago

amerkoleci commented 6 years ago

Geneate xml documentation only when compling in Release. Update Microsoft.NETCore.UniversalWindowsPlatform to 5.4.0. Remove not needed netcoreapp1.0 target framework. Cleanup some macro to use WINDOWS_UWP instead of STORE_APP. XAudio fix desktop Version 2.7 on non UWP platform. Direct3D12 some documentation improvements and some helper logic.

amerkoleci commented 6 years ago

This fixes also https://github.com/MonoGame/MonoGame/issues/5986

xoofx commented 6 years ago

The build is failing, could you have a look?

amerkoleci commented 6 years ago

Strange, seams tha appveyor cannot resolve uap10.0 target, can there be any settings?

I updated uwp platform to 10.0.14393.0

amerkoleci commented 6 years ago

Locally I can build without issues.

error MSB4057: The target "Pack" does not exist in the project.

amerkoleci commented 6 years ago

Fixed now

amerkoleci commented 6 years ago

Fixes also the native effects dlls path, see #941

xoofx commented 6 years ago

I would prefer that you remove 7dcca8b as part of this PR. The reason is that I didn't want Direct3D12 to follow the previous legacy API (that inherited from the SlimDX decisions) and wanted them to be much closer to the underlying C++ code. That's why there is little manual code written for Direct3D12 and I would like to keep it like this.

In the future, If you could split the PR per issue addressed, it would help to let them go through more easily (specially when they are independent)

amerkoleci commented 6 years ago

I will revert the commit, i know but as i coded I saw the issue and decided to fix it :) but will submit separated PR in future

amerkoleci commented 6 years ago

Should be good now

xoofx commented 6 years ago

Thanks!