search

sharpdx / SharpDX

SharpDX GitHub Repository
http://sharpdx.org
MIT License
1.69k stars 641 forks source link

Direct3D12 Fence Value should be ulong instead of long #948

Closed amerkoleci closed 6 years ago

amerkoleci commented 6 years ago

As title says, Fence, Signal and CommandQueue now uses long, should be ulong as native UINT64 type, any thought?

I can submit PR

xoofx commented 6 years ago

If we could stay with long, I would prefer. Otherwise it will have to go through a longer route of updating SharpGen (to support unsigned) and activate only this option for Direct3D12...

amerkoleci commented 6 years ago

I see but in that case long wont fit as u long

xoofx commented 6 years ago

what is it used for? we have plenty of uint that have been used as int in SharpDX for the past years and while not ideal, I haven't heard any complain about this...

amerkoleci commented 6 years ago

I understand what you mean and for me is ok, just wanted to point out the logic :)