search

sharpdx / SharpDX

SharpDX GitHub Repository
http://sharpdx.org
MIT License
1.69k stars 641 forks source link

Cannot add SharpDX source projects to own solution #968

Closed ziriax closed 6 years ago

ziriax commented 6 years ago

It seems that to build SharpDX from sources, it uses MSBuild stuff from sharpdx.targets.

This file refers to $(SolutionDir), but this links the SharpDX projects to the SharpDX solution.

Changing this to $(ProjectDir)..\.. instead allows the SharpDX projects to be added to any solution.

I have a pull request ready, but before submitting this, I might be missing the reason why $(SolutionDir) is used in sharpdx.targets?

xoofx commented 6 years ago

I have a pull request ready, but before submitting this, I might be missing the reason why $(SolutionDir) is used in sharpdx.targets?

Don't remember and using $(ProjectDir)..\.. sounds fine

ziriax commented 6 years ago

971