search

sharpenrocks / Sharpen

Visual Studio extension that intelligently introduces new C# features into your existing codebase
https://sharpen.rocks
MIT License
418 stars 32 forks source link

Progress bar background does not have proper color #1

Closed ironcev closed 5 years ago

ironcev commented 6 years ago

The color used to be black with white text on the Dark VS Theme. It is gray now and the text is not visible:

image

It looks like this happened when we switched to tree view instead of list view. Analyse the changes between 2f4fddd92d627ace188d10046a740b6d9035173d and 9b63ac20999e2537a92fb6866218c9e222bad227.

kurtanr commented 5 years ago

Wanted to help out a bit, and since I am familiar with WPF, this looked like a nice issue to start with...

I am using VisualStudio 2019 Community Edition 16.2.0 and I was not able to reproduce the issue on master branch. Then I went to the suggested commit which introduced the issue (9b63ac2) and built the installer from that commit. At that time (version 0.1), Sharpen did not support VS2019, so to make the installer work, I had to do some change in "source.extension.vsixmanifest" and had to update some nugets. The issue still could not be reproduced.

As a reference, I am attaching how the progress bar background looks in VS2019:

theme_dark

Maybe the issue was fixed by Microsoft when they fixed some issue in Visual Studio. Can you still reproduce the issue?

ironcev commented 5 years ago

Thanks for your contribution @kurtanr! I've just tried to reproduce the issue in VS2017 and VS2019 on three different themes (Dark, Light, and Blue) and I was not able to reproduce the issue.

image

image

image

Even more, I was switching the theme while the progress bar was running and everything worked fine. The "Please wait" dialog was changing look and feel as expected.

My assumption is that the issue was connected to #15. The #15 was blocking VS UI and I guess also affected rendering.

Since this issue cannot be reproduced any more I'll close it.

Thanks once again for your contribution!