search

sharplispers / clx

a fork of crhodes' fork of danb's fork of the CLX library, an X11 client for Common Lisp
Other
116 stars 46 forks source link

fix some issues #120

Closed mgi closed 5 years ago

mgi commented 5 years ago

To be continued...

dkochmanski commented 5 years ago

@mgi please don't use your time on that. I have a strong conviction now that we must revert the change of struct->class, because issues like this one will come up one after one and we really don't have any good argument to keep it (no new functionality, even not introducing clos, because CLX had the ability to use standard-class in defnie-clx-class).

dkochmanski commented 5 years ago

I've created pure-clos branch to not lose these changes. master is reset to state from before the original merge.

mgi commented 5 years ago

Too bad, I should have been more responsive on these issues but did not received any notification from github (I should check my settings). I was in the process of checking that any function/getter/setter in the manual was defined.

I restate that those patches was more for maintainability than anything else. I knew that define-clx-class can expand to both destruct or defclass but I think that this feature is bit of a hack (and CLOS is in the standard anyway).

Anyway as the choice is made now, I think you can ditch the pure-clos branch because we don't have the man power to maintain both branch.

Best regards and thanks for your work 👍