search

sharplispers / clx

a fork of crhodes' fork of danb's fork of the CLX library, an X11 client for Common Lisp
Other
116 stars 46 forks source link

Feature clasp take 2 #136

Closed kpoeck closed 5 years ago

kpoeck commented 5 years ago

Tests done with clasp:

To test for regressions in other lisps, test with sbcl and ccl

as I put in the code: define-constant-uneql is needed, since constants with non-eql value have undefined behaviour when redefined. Compiling and Loading and file may redefine the constant, please see http://www.sbcl.org/manual/#Defining-Constants. This interpretation is shared by sbcl and clasp

dkochmanski commented 5 years ago

Please undo and add my change unstead.

Dnia 6 stycznia 2019 13:43:47 CET, Karsten Poeck notifications@github.com napisał(a):

kpoeck commented on this pull request.

@@ -438,7 +438,7 @@

(deftype xatom () '(or string symbol))

-(defconstant +predefined-atoms+ +(define-constant-uneql +predefined-atoms+

What is the change you require here? (a) I undo all define-constant-uneql and shadow defconstant as you propose or (b) I just undo the define-constant-uneql and wait for you to shadow defconstant separately?

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/sharplispers/clx/pull/136#discussion_r245507295

-- Wysłane za pomocą K-9 Mail.

kpoeck commented 5 years ago

I hope I have done all what you requested. Tested with clasp, sbcl and ccl

dkochmanski commented 5 years ago

lgtm, thank you. normally I'd ask you to squash first and third commit, but I'll simply squash all of them so there is no need to take an action on your side.

nb: in my ideal world you'd test it with ecl too :-)