search

sharplispers / clx

a fork of crhodes' fork of danb's fork of the CLX library, an X11 client for Common Lisp
Other
114 stars 46 forks source link

Export composite-get-overlay-window, and document it #158

Closed equwal closed 4 years ago

equwal commented 4 years ago

Exported this (since it is needed anyway for the other exported symbol composite-release-overlay-window).

Added some documentation strings to these.

JMC-design commented 4 years ago

Looks fine to me.

There should be a warning added somewhere. If no composite manager is running then the client requesting the overlay window becomes responsible for redrawing everything. If the client cannot setup a pass through input on the overlay window, which they currently cannot because I haven't pushed xfixes yet, then the overlay will prevent any clients from receiving input. So without a composite manager already running the overlay window is not usable.

equwal commented 4 years ago

Looks fine to me.

There should be a warning added somewhere. If no composite manager is running then the client requesting the overlay window becomes responsible for redrawing everything. If the client cannot setup a pass through input on the overlay window, which they currently cannot because I haven't pushed xfixes yet, then the overlay will prevent any clients from receiving input. So without a composite manager already running the overlay window is not usable.

I hadn't considered that use case, since I am working on the window manager (not applications usage).

I added a relevant note in this docstring, and added a few more docstrings.

dkochmanski commented 4 years ago

lgtm, thanks!