search

sharplispers / clx

a fork of crhodes' fork of danb's fork of the CLX library, an X11 client for Common Lisp
Other
116 stars 46 forks source link

extensions: randr: fix RR-GET-OUTPUT-INFO indices #172

Open paulapatience opened 4 years ago

paulapatience commented 4 years ago

The CRTC-START index was incorrect, which caused RR-GET-OUTPUT-INFO to return bogus CRTCs, modes, clones, and name.

Additionally, document the function's multiple return values and declaim its type. The latter required adding some types and adjusting some existing types and constants.

Finally, reindent RR-GET-OUTPUT-INFO, wrap some overlong lines, and clean up some comments and whitespace.

dkochmanski commented 4 years ago

please resolve conflicts; after that I'm OK with merging this as is. thank you.

einsiedlerspiel commented 1 year ago

What's the status on this?

paulapatience commented 1 year ago

What's the status on this?

I can take a look at this again soon. However, I wonder if I should revert the &keys back to &optionals, as @JMC-design disapproved of the change in https://github.com/sharplispers/clx/pull/174#pullrequestreview-491477704.

dkochmanski commented 1 year ago

key is fine, it makes the interface better. optional arguments get nasty quick if there is more than one.