search

sharplispers / clx

a fork of crhodes' fork of danb's fork of the CLX library, an X11 client for Common Lisp
Other
116 stars 46 forks source link

XRandR Improvements #193

Closed scymtym closed 1 year ago

scymtym commented 2 years ago
JMC-design commented 2 years ago

Does the rr-panning-put really still not work? I was kinda hoping to see what the issue was with that.

scymtym commented 2 years ago

Sorry, this was meant to be a draft, not ready for review. Since I promised @JMC-design to let them have a look.

dkochmanski commented 2 years ago

OK, thanks. I've converted PR to draft.

scymtym commented 2 years ago

Does the rr-panning-put really still not work? I was kinda hoping to see what the issue was with that.

@JMC-design Not sure which code you are referring to. xlib/xrandr:set-panning does not work in this draft pull request because define-accessor uses/generates symbols in multiple different packages. I think I have a trivial fix that, but I have to check that the fix does not break other things first.

scymtym commented 2 years ago

One issue I couldn't come to a decision on: should the synchronous operations that receive a success or failure indication in the reply just return that value or signal a condition on failure (example: get-output-info returns either :success or :failure as the first return value). I lean towards just returning the value and leave the construction of convenience layers to clients but that does, of course, make the base interface less convenient.

Similarly, some operations return "meta data" in the form of timestamps and "configuration timestamps" along with the primary data. The order of return values is currently mostly modeled after the order of fields in the respective XRandR reply structure. However, it might make sense to return the meta data values as the final values since they seem to not always be needed.