sharplispers / clx

a fork of crhodes' fork of danb's fork of the CLX library, an X11 client for Common Lisp
Other
114 stars 46 forks source link

Enable CLX for LispWorks 8.x and later (confirmed by McCLIM) #206

Closed binghe closed 8 months ago

binghe commented 8 months ago

Hi,

Recently McCLIM has been greatly improved. I just tried loading McCLIM in LispWorks 8.0.1 (on macOS) and it seems that the only blocking issue is CLX, which has disabled the support of LispWorks versions 8.x and later:

#-(or lispworks6 lispworks7)
(error "Sorry, your ~S lisp version ~S is not currently supported.  ~
        Patches are welcome."
       (lisp-implementation-type) (lisp-implementation-version))

But actually the code runs very well under LispWorks 8.0.1, and by disabling the above code I can indeed run McCLIM in LispWorks:

Schermata 2023-12-29 alle 19 21 50

Therefore I propose this trivial patch which enables all LispWorks versions 6.x and later.

NOTE: The existing CLX code doesn't support connecting to X11 (Xquartz) server listening on unix domain sockets, on macOS. As a workaround, I had to SSH to localhost with X11 forwarding enabled (-X) and then run the X11-based LispWorks console image and got the above screenshot. I will take a look at CLX code and see if the support of unix domain sockets can be added (no estimates on time).

--Chun

dkochmanski commented 8 months ago

Looks good, thanks!