search

sharplispers / clx

a fork of crhodes' fork of danb's fork of the CLX library, an X11 client for Common Lisp
Other
116 stars 46 forks source link

feature + export in RandR #84

Closed mgi closed 7 years ago

dkochmanski commented 7 years ago

Changes look fine for me. Also tested with McCLIM (on of biggest clx clients) and it doesn't seem to break things. I will merge it this evening unless someone is against that. As far as I understand, this change is due to the fact, that randr is more complete than xinerama, am I right? Thank you for waiting.

mgi commented 7 years ago

Daniel Kochmanski notifications@github.com writes:

Changes look fine for me. Also tested with McCLIM (on of biggest clx clients) and it doesn't seem to break things. I will merge it this evening unless someone is against that.

Thank you for this. I don't think that McCLIM uses Xinerama (or Randr) BTW.

As far as I understand, this change is due to the fact, that randr is more complete than xinerama, am I right?

Yes, Xinerama extension in clx contains close to no features. And Xinerama is known as the "old way" of doing multihead. While Randr is the "modern" way and the code is almost complete.

IMO, you could also remove the xinerama.lisp file.

Thank you for waiting.

It's ok. Thanks to you for reviewing and maintaining clx. -- Manuel Giraud

dkochmanski commented 7 years ago

merged, thanks!