sharplispers / cormanlisp

Corman Lisp
MIT License
570 stars 78 forks source link

GC updates, stability updates, misc. fixes, minesweeper neural net example #23

Closed rgcorman closed 7 years ago

rgcorman commented 7 years ago

Various features and fixes I've added in the last month. GC can now turn on or off hardware-assist: (cl::hardware-gc t) (cl::hardware-gc nil) It is on by default and works better with Windows callbacks. Port of minesweeper neural net/genetic program added to examples. Fixed (SETF SUBSEQ) IDE now saves open documents and positions when you exit and restart. Added various Win32 calls and structure types.

arbv commented 7 years ago

It seems everything is fine now with your git configuration.

I can imagine that making Quicklisp work with Corman Lisp is a big task. I believe that the hardest part is porting a modern version of ASDF to it (version 3 at the time of writing). The half way to porting ASDF is, I believe, making UIOP work properly with Corman Lisp because ASDF3 heavily relies on it. It is a cool library too. It seems that this work needs changes on both CL side and libraries side.

As about Hardware GC, it seems that it causes some issues, unfortunately. I cannot run your minesweeper example for longer than ~6-10 generation with Hardware GC enabled (otherwise it runs just fine). I will try to investigate this problem further. My machine a laptop with Windows 10 Pro x64 (Anniversary Update), nothing really special about it.

P. S. Minesweepers is a cool program, BTW. One of the kind that makes me realize that I am just a young padawan ;)

rgcorman commented 7 years ago

Hmm, I have been able to run minesweepers on each of my workstations (all running windows 10 pro x64 anniversary) for extended periods, even with Hardware GC on, with the latest updates I checked in. In fact I've never seen it crash. But I do remember that I used to see some differences in machines--where some would crash and others wouldn't (before your safecall fix and the new changes I made).

Can you make sure you've done a clean full rebuild? If you are still getting a crash, with hardware-gc on, then we should probably have hardware-gc off by default in the master (release) version.

--Minesweepers is a cool program, BTW. One of the kind that makes me realize that I am just a young padawan ;)

I just ported it from C++, partly because porting a program like that to lisp is a good way to understand what the program is doing and I am trying to learn more about neural nets.

Don't sell yourself short--you have some excellent skills to be able to do the kind of improvements you've been doing to Corman Lisp.

arbv commented 7 years ago

Hello, Roger!

Thanks for kind words! I wasn't able to dedicate some time to Corman Lisp recently.

I tried to investigate this problem after full clean rebuild and it seems that the CL won't crash when the 'minesweepers' demo running from within IDE with Hardware GC enabled. But it will crash after ~10 generations when started as separate application. It seems it is not directly related to the Hardware GC. I will try to investigate the problem further to find some additional detailes.

06.02.2017 22:58, Roger Corman пишет:

Hmm, I have been able to run minesweepers on each of my workstations (all running windows 10 pro x64 anniversary) for extended periods, even with Hardware GC on, with the latest updates I checked in. In fact I've never seen it crash. But I do remember that I used to see some differences in machines--where some would crash and others wouldn't (before your safecall fix and the new changes I made).

Can you make sure you've done a clean full rebuild? If you are still getting a crash, with hardware-gc on, then we should probably have hardware-gc off by default in the master (release) version.

--Minesweepers is a cool program, BTW. One of the kind that makes me realize that I am just a young padawan ;)

I just ported it from C++, partly because porting a program like that to lisp is a good way to understand what the program is doing and I am trying to learn more about neural nets.

Don't sell yourself short--you have some excellent skills to be able to do the kind of improvements you've been doing to Corman Lisp.

From: Artem Boldarev [mailto:notifications@github.com] Sent: Saturday, February 04, 2017 9:45 AM To: sharplispers/cormanlisp cormanlisp@noreply.github.com Cc: Roger Corman roger@corman.net; State change state_change@noreply.github.com Subject: Re: [sharplispers/cormanlisp] GC updates, stability updates, misc. fixes, minesweeper neural net example (#23)

It seems everything is fine now with your git configuration.

I can imagine that making Quicklisp work with Corman Lisp is a big task. I believe that the hardest part is porting a modern version of ASDF to it (version 3 at the time of writing). The half way to porting ASDF is, I believe, making UIOP work properly with Corman Lisp because ASDF3 heavily relies on it. It is a cool library too. It seems that this work needs changes on both CL side and libraries side.

As about Hardware GC, it seems that it causes some issues, unfortunately. I cannot run your minesweeper example for longer than ~6-10 generation with Hardware GC enabled (otherwise it runs just fine). I will try to investigate this problem further. My machine a laptop with Windows 10 Pro x64 (Anniversary Update), nothing really special about it.

P. S. Minesweepers is a cool program, BTW. One of the kind that makes me realize that I am just a young padawan ;)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/sharplispers/cormanlisp/pull/23#issuecomment-277462252, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAOZ42LZn2AGd4TDR4xApo53I3yPY8kFks5rZLktgaJpZM4L2pg1.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sharplispers/cormanlisp/pull/23#issuecomment-277811194, or mute the thread https://github.com/notifications/unsubscribe-auth/AHFhrwqBiTfYsuHc2JUHBcNoy-a1umzkks5rZ4l1gaJpZM4L2pg1.