search

sharplispers / cxml

Closure XML - A Common Lisp XML Parser
http://common-lisp.net/project/cxml/
Other
12 stars 5 forks source link

Named readtables #5

Open ruricolist opened 6 years ago

ruricolist commented 6 years ago

I'd like to propose switching CXML to use named-readtables. It would allow removing the component classes from the .asd file, moving it in a much more declarative direction.

This isn't technically challenging (I already did it for FXML) but it would require a coordinated change across closure-common and CXML so I wanted to raise it for discussion first.

You can see the contemplated changes in these commits:

https://github.com/ruricolist/FXML/commit/fd1ffd96650c1ae376886942f1038b9374073622 https://github.com/ruricolist/FXML/commit/fd1ffd96650c1ae376886942f1038b9374073622

slyrus commented 6 years ago

I'm all for it!

scymtym commented 6 years ago

I'm all for it!

Same.

You can see the contemplated changes in these commits:

ruricolist/FXML@fd1ffd9 ruricolist/FXML@fd1ffd9

Both links point to the same commit. That commit lgtm, though.

@ruricolist Since we all agree about wanting this, would you make a pull request?