search

sharplispers / ironclad

A cryptographic toolkit written in Common Lisp
BSD 3-Clause "New" or "Revised" License
166 stars 28 forks source link

`make-kdf` and the `digest` parameter #16

Closed lovrolu closed 5 years ago

lovrolu commented 5 years ago

When using the PBKDF algorithms with make-kdf, I would expect digest to accept either a keyword symbol or a symbol from the ironclad package, as is the convention for numerous other functions (make-digest, make-cipher, make-mac, etc.). However, it seems to only accept symbols from the ironclad package.

The documentation for make-kdf should also be improved to explicitly mention what digest should be.

glv2 commented 5 years ago

Commit 0055c420a87e99afcc9de52574866613bac9ad6c should fix this bug. Thanks for the report.

lovrolu commented 5 years ago

I've created a PR that clarifies the documentation as well. :-) See #17.

glv2 commented 5 years ago

Merged, thanks.