sharplispers / ironclad

A cryptographic toolkit written in Common Lisp
BSD 3-Clause "New" or "Revised" License
166 stars 28 forks source link

HKDF #19

Closed mgi closed 5 years ago

mgi commented 5 years ago

Hi,

I'm in the process of adding hmac-kdf RFC 5869 to ironclad. So far so good, but I don't know what to do with the optional info vector.

Should I modify the derive-key interface to have it as a parameter? Should It be a slot into the new hmac-kdf class?

Thanks

glv2 commented 5 years ago

The info vector seems to have the same role as the additional-data vector for argon2, therefore the additional-data keyword of the make-kdf function can be used.

I'd say:

Basically, it should be pretty similar to what is done with additional-data for the argon2 class.

glv2 commented 5 years ago

Implemented and merged (PR #20).