use ma.log10 instead of np.log10 in interp.hght()

sharppy / SHARPpy

Sounding/Hodograph Analysis and Research Program in Python

https://sharppy.github.io/SHARPpy/index.html

Other

216 stars 112 forks source link

use ma.log10 instead of np.log10 in interp.hght() #168

Closed ahijevyc closed 4 years ago

ahijevyc commented 5 years ago

Should ma.log10() be used at the end of the interp.hght() function instead of np.log10()?

return generic_interp_pres(ma.log10(p), prof.logp[::-1], prof.hght[::-1])

I would like to avoid the log10 of zero warning, but don't want to break anything. I tried a pull request, but couldn't figure out how to isolate this change from the rest of my changes.

wblumberg commented 4 years ago

Hi @ahijevyc

I went ahead and incorporated this change into Andover. It passed all the tests, so it doesn't look like it's going to disrupt anything! Thanks for the recommendation.

Greg