Created NUCAPS decoder & unit test

sharppy / SHARPpy

Sounding/Hodograph Analysis and Research Program in Python

https://sharppy.github.io/SHARPpy/index.html

Other

220 stars 110 forks source link

Created NUCAPS decoder & unit test #227

Closed Jeff-Szkodzinski closed 2 years ago

Jeff-Szkodzinski commented 2 years ago

Hi Tim and Greg,

I'm submitting a new pull request that includes the NUCAPS decoder and unit test. I ran tests on the real-time NUCAPS data feed and confirmed that the decoder was able to successfully parse the cloud info from the text file. There's another commit that includes the changes to account for missing values in either the wind speed or wind direction arrays. Let me know if you're able to merge these changes.

Thanks! Jeff

resmaili commented 2 years ago

Jeff, I made some changes to this pull request, can I be given write access in the original repo (https://github.com/Jeff-Szkodzinski/SHARPpy.git)?

Jeff-Szkodzinski commented 2 years ago

Rebekah, I'm wondering if I should just close out my pull request since your SHARPpy-NUCAPS repository already contains my previous commits, plus the ones you added relating to MetOp. And since the new repo you created will likely be kept more up-to-date than mine, it probably would be better to just initiate pull requests originating from SHARPpy-NUCAPS going forward. Let me know if that's the way you think we should proceed.

Jeff

Jeff-Szkodzinski commented 2 years ago

Closing pull-request since the same commits will be imported from NUCAPS/SHARPpy.