search

sharppy / SHARPpy

Sounding/Hodograph Analysis and Research Program in Python
https://sharppy.github.io/SHARPpy/index.html
Other
219 stars 112 forks source link

Stations With Special Characters #38

Closed keltonhalbert closed 9 years ago

keltonhalbert commented 9 years ago

Stations with special characters currently do not work for the model data. This is because the URLs on the data server use a different syntax (for example, # gets replaced with %23). It should be a relatively easy fix, but I'm opening an issue because it is something routinely forget about and should be fixed at some point.

wblumberg commented 9 years ago

@tsupinie has made some leeway on this bug with the new picker. It's either that or he's made changes in one of his bug fixes for the HTML-based SHARPpy picker and fixed this issue. I'm not certain where the fix may be. Tim could probably elaborate on his changes for this.

wblumberg commented 9 years ago

It's not in the newest edition of the picker, but I remember Tim mentioning that fix was on his list.

keltonhalbert commented 9 years ago

Yeah, I had seen him talk about it on Central OK Wx. I figured I would do this to help maintain bug reporting standards as things start to take off and we get more suggestions/reports from other people.

wblumberg commented 9 years ago

Yeah, I agree. With the combination of Facebook, email, ST, Twitter, the whole bugs/recommendations reporting will get out of hand if we don't control them correctly (strongly agreeing with your ST post).

keltonhalbert commented 9 years ago

I've implemented a fix for this issue that has been pushed to the map-selector branch. The bug fix will not go live until the map-selector branch is ready to be merged with the master branch, but I'm going to go ahead and close this issue since it has been resolved.

It turns out, URLLIB has a function for handling this sort of formatting. I just wrapped the URL in that function in all is well. This means that all data sites should now work.