search

sharpstone / heroku-bouncer

A Heroku OAuth middleware with no other work to do
MIT License
41 stars 15 forks source link

Bouncer should fail hard if the required configuration is not present #62

Open phil opened 6 years ago

phil commented 6 years ago

https://github.com/heroku/heroku-bouncer/blob/7760adc7b295036d511ad0c92975fea9d35087de/lib/heroku/bouncer/builder.rb#L37

wuputah commented 6 years ago

options[:disabled] is fine, it's the impact that this has - I think you either want it to return a 500 error if it's disabled, or crash the app (System.exit).

Would it be annoying for bouncer to be "always enabled" for local development, or have to be wrapped in an if clause ( like if Rails.env.production? ) of some kind to be disabled? What's the current common use case for development?