sharu725 / online-cv

A minimal Jekyll Theme to host your resume (CV) on GitHub with a few clicks.
https://online-cv.webjeda.com
Other
3.12k stars 5.92k forks source link

Delete jquery, bootstrap #462

Closed bigscoop closed 2 months ago

bigscoop commented 5 months ago

Updated jquery to v.3.7.1

sharu725 commented 2 months ago

Nice, can you use this instead of a local version

<script src="https://code.jquery.com/jquery-3.7.1.slim.min.js" integrity="sha256-kmHvs0B+OpCW5GVHUNjv9rOmY0IvSIRcf7zGUDTDQM8=" crossorigin="anonymous"></script>

Also, delete the local jquery file.

bigscoop commented 2 months ago

@sharu725 done :+1:

sharu725 commented 2 months ago

@bigscoop I suggest you use the entire script tag I provided and remove any local copies. We do not want these files as local assets.

So instead of

<script
  type="text/javascript"
  src="{{site.baseurl}}/assets/plugins/jquery-3.7.1.slim.min.js"
></script>

use

<script src="https://code.jquery.com/jquery-3.7.1.slim.min.js" integrity="sha256-kmHvs0B+OpCW5GVHUNjv9rOmY0IvSIRcf7zGUDTDQM8=" crossorigin="anonymous"></script>

Also, delete local jquery files.

bigscoop commented 2 months ago

But then it would be impossible to start it locally while being offline. And we save only around 60 kilobytes of storage space

sharu725 commented 2 months ago

Hmm.. on a second thought I just tried the site without these scripts, it works just as it used to be. I think we are loading it for no reason.

Try it on your end and remove both if things look fine.

Do keep the analytics script though.

bigscoop commented 2 months ago

Tested it locally, works also without jquery. Deleted it

sharu725 commented 2 months ago

Awesome! Please delete this as well along with the file.

<script
  type="text/javascript"
  src="{{site.baseurl}}/assets/plugins/bootstrap/js/bootstrap.min.js"
></script>
bigscoop commented 2 months ago

also works. done