search

sharu725 / online-cv

A minimal Jekyll Theme to host your resume (CV) on GitHub with a few clicks.
https://online-cv.webjeda.com
Other
3.12k stars 5.92k forks source link

Add LeetCode icon on Contact page, from SimpleIcons CDN #474

Closed plinkr closed 1 month ago

plinkr commented 1 month ago

This pull request replaces the FontAwesome generic code icon previously used for LeetCode with an SVG icon from the SimpleIcons CDN. The change ensures that the LeetCode section of the sidebar is visually represented with the correct icon.

An issue was submitted to FontAwesome several years ago to integrate the LeetCode icon, but it has not yet been resolved. This solution, while not ideal due to the reliance on an external CDN from SimpleIcons, serves as a temporary fix. I understand that this may not be desirable for everyone, so I'll be using this solution in my fork temporarily, feel free to close this PR if you don't want to use SimpleIcons. If FontAwesome implements the LeetCode icon in the future, we can update to that icon and remove the external dependency on SimpleIcons.

nelsonmestevao commented 1 month ago

This type of issue come up a couple of times already. I think FontAwesome is not the best bet anymore. There are plenty of great alternatives now. For example, https://tabler.io/icons as a rich set of brand icons including LeetCode and many others that can be used across all the template in a consistent manner.

What do you think @sharu725? Should we close this one and start working on migrating to a new library?

sharu725 commented 1 month ago

Absolutely.

nelsonmestevao commented 1 month ago

I will soon try to do that then :pray: